Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-aspects produces aspectj compiler warnings "adviceDidNotMatch" [SPR-12239] #16853

Closed
spring-issuemaster opened this issue Sep 23, 2014 · 6 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Sep 23, 2014

Janning Vygen opened SPR-12239 and commented

I was adding spring-aspects to use @Transactional with compile time weaving. With STS the AJDT eclipse module produces a warning like

org.springframework.mock.staticmock.AbstractMethodMockingControl has not been applied [Xlint:adviceDidNotMatch]

All advices in the spring-aspects lib should have @SuppressAjWarning
Some already have like AbstractTransactionAspect in line 59


Affects: 4.1 GA

Issue Links:

  • #17052 spring-aspects produces still some aspectj compiler warnings "adviceDidNotMatch"

Referenced from: commits 439ea90, 6950d55

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Sep 30, 2014

Janning Vygen commented

Pull Request:
#655

It is my first contribution to spring. I hope everything is fine. I have watched the contribution rules, signed the CLA and changed the dates in the license

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 1, 2014

Stéphane Nicoll commented

Thanks for the PR!

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 17, 2014

Janning Vygen commented

With 4.1.2 most warnings went away but I git a new one not recognized before:

advice defined in org.springframework.mock.staticmock.AnnotationDrivenStaticEntityMockingControl has not been applied [Xlint:adviceDidNotMatch] line 115

So line 115 and line 117 in AnnotationDrivenStaticEntityMockingControl may need this @SuppressAjWarning annotation too. But I am not sure because in these lines only pointcuts are defined but not advices. In my understanding these are two different things. But maybe the warning applies to pointcuts too.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 17, 2014

Stéphane Nicoll commented

This one isn't new so we just didn't took it into account with your original PR. Could you please create a new improvement and we'll take it from there. Thanks!

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 17, 2014

Janning Vygen commented

Raised new issue and sent pull request
#17052

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 17, 2014

Stéphane Nicoll commented

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.