Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate entries in ResolvableType cache [SPR-12275] #16880

Closed
spring-projects-issues opened this issue Sep 30, 2014 · 1 comment
Closed

Duplicate entries in ResolvableType cache [SPR-12275] #16880

spring-projects-issues opened this issue Sep 30, 2014 · 1 comment
Assignees
Labels
in: core status: backported type: bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Sep 30, 2014

Stéphane Nicoll opened SPR-12275 and commented

While doing some investigations on #16021 we discovered that the ResolvableType internal cache was holding a lot of duplicates for simple types (i.e. String, Integer, etc).

It turns out that we are using too much metadata to compute the key when the class has no generic information. so setFoo(String foo) and setBar(String bar) would result in two entries in the cache because the TypeProvider is different.


Affects: 4.0.7, 4.1 GA

Issue Links:

  • #16021 memory leak in class org.springframework.core.ResolvableType

Backported to: 4.0.8

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 30, 2014

Stéphane Nicoll commented

Investigating this a bit further, the cost of creating a simple wrapper around the class is lower than checking the cache so we're now avoiding the cache altogether for simple types (i.e. non generic, simple types).

@spring-projects-issues spring-projects-issues added type: bug status: backported in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.1.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core status: backported type: bug
Projects
None yet
Development

No branches or pull requests

2 participants