Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Reference documentation @PathVariable, @RequestHeader & @RequestParam using Map<String, String> [SPR-12347] #16952

Closed
spring-projects-issues opened this issue Oct 19, 2014 · 5 comments
Assignees
Labels
in: web type: documentation type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 19, 2014

Manuel Jordan opened SPR-12347 and commented

Summary: I have checked the Spring Framework Reference Documentation and there is no an example about @PathVariable working together with Map<String, String>

Perhaps same situation for @RequestHeader, @RequestParam too


Affects: 4.0.7, 4.1.1

Issue Links:

  • #21475 @PathVariable's javadoc wrongly states it supports MultiValueMaps
  • #16910 Allow @PathVariable to have default value on @ModelAttribute methods

Referenced from: commits df09023

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 20, 2014

Rossen Stoyanchev commented

Also the @RequestMapping Javadoc.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 20, 2014

Manuel Jordan commented

Perhaps same appreciation for each annotation in its javadoc?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 23, 2014

Manuel Jordan commented

Has been fixed for Spring 4.0.x too?
Perhaps same appreciation for 3.2.x

The API has been updated too? (for each annotation)

Thank you.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 23, 2014

Rossen Stoyanchev commented

Note that it is there in Javadoc on @RequestMapping even in 3.2 (see here). It's also partially documented in the reference. I just added it in more places.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 23, 2014

Manuel Jordan commented

Thanks by the reminder. I forgot that detailed information about that annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web type: documentation type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants