Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.springframework.ui.ModelMap.mergeAttributes(Map) makes inefficient use of keySet iterator [SPR-12363] #16968

Closed
spring-projects-issues opened this issue Oct 22, 2014 · 1 comment
Closed

org.springframework.ui.ModelMap.mergeAttributes(Map) makes inefficient use of keySet iterator [SPR-12363] #16968

spring-projects-issues opened this issue Oct 22, 2014 · 1 comment
Assignees
@snicoll
Labels
in: core type: enhancement
Milestone
4.1.2

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 22, 2014 •
edited

Sang Gi Ryu opened SPR-12363 and commented

org.springframework.ui.ModelMap.mergeAttributes(Map) makes inefficient use of keySet iterator instead of entrySet iterator.

Affects: 4.1.1

Issue Links:

  • #16961 BeanFactoryAnnotationUtils,qualifiedBeanOfType, Inefficient use of keySet iterator.
  • #17037 MessageHeaderAccessor copyHeaders... tuning

Referenced from: pull request #672, and commits d625229, 73e398a

2 votes, 2 watchers
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 24, 2014

Stéphane Nicoll commented

Merged, thanks.

@spring-projects-issues spring-projects-issues added type: enhancement in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.1.2 milestone Jan 11, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: core type: enhancement
Projects
None yet
Milestone
4.1.2
Development

No branches or pull requests
2 participants
@snicoll @spring-projects-issues