String comparison using .equals() in ASM ClassReader [SPR-12382]

[spring-projects-issues]

Ahn Jung Su opened SPR-12382 and commented

Comparison of String objects using == or != in org.springframework.asm.ClassReader.readMethod(ClassVisitor, Context, int)

if (mw.cw.cr == this && signature==mw.signature) {
...
}

Actually Type of signature and mw.signature are String.
It is better to use .equals()

---

Affects: 4.1.1

Issue Links:

• #16970 Inefficient new Byte, Integer, Character constructor calls in ASM ClassReader

Referenced from: pull request #678, and commits cb09513

[spring-projects-issues]

Ahn Jung Su commented

I changed source == operations to equlas() method. and commit

pull request : #678

[spring-projects-issues]

Juergen Hoeller commented

I've applied this to master in a more defensive fashion including a null check.

Juergen