Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce previous SpringSessionSynchronization(SessionHolder, SessionFactory) constructor signature [SPR-12400] #17008

Closed
spring-projects-issues opened this issue Oct 30, 2014 · 4 comments
Assignees
Labels
in: data type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 30, 2014

Lari Hotari opened SPR-12400 and commented

Grails GORM depends on this constructor

public SpringSessionSynchronization(SessionHolder sessionHolder, SessionFactory sessionFactory)

this constructor was removed by commit 5cbb1fc

more information
grails/grails-data-mapping#46


Affects: 4.1 GA, 4.1.1

Referenced from: commits 7aff575

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 30, 2014

Juergen Hoeller commented

I've just noticed that the SpringSessionSynchronization class itself isn't actually public, so you're forced to construct it reflectively in any case... So I'm wondering: Should we make it public to begin with? We could also make it public in 4.0.8 if that helps...

That's also why that constructor has been changed without notice and without overloading: The class wasn't public so we didn't expect anyone to call it. Turning it to public now would make that exposure to GORM clearer, wouldn't it?

Juergen

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 30, 2014

Graeme Rocher commented

Making it public would help yeah

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 30, 2014

Lari Hotari commented

org.springframework.orm.hibernate4.SpringFlushSynchronization is also instantiated via reflection so could we also make that public?

https://github.com/grails/grails-data-mapping/blob/3b91e55/grails-datastore-gorm-hibernate4/src/main/groovy/org/codehaus/groovy/grails/orm/hibernate/GrailsSessionContext.java#L231-L236

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 30, 2014

Juergen Hoeller commented

Made both synchronization classes public now and reintroduced the original constructor for 4.1.2. I'll make the classes public in 4.0.8 as well.

Juergen

@spring-projects-issues spring-projects-issues added in: data type: task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.1.2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data type: task
Projects
None yet
Development

No branches or pull requests

2 participants