Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SockJsClient does not stop transports on invocation of stop() [SPR-12417] #17024

spring-projects-issues opened this issue Nov 7, 2014 · 1 comment
in: web type: bug


Copy link

@spring-projects-issues spring-projects-issues commented Nov 7, 2014

Joakim Örtbrant opened SPR-12417 and commented

Implementation of stop() method in SockJsClient will never actually do anything since first condition:
if (!isRunning()) is always false.
Please remove negation and change to:
if (isRunning())

Affects: 4.1.1

Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 7, 2014

Juergen Hoeller commented

Rossen fortunately fixed this a few days ago in master, so this is already available in recent 4.1.2 snapshots.


@spring-projects-issues spring-projects-issues added type: bug in: web labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.1.2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
in: web type: bug
None yet

No branches or pull requests

2 participants