Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SockJS client references from 0.3.4 to 1.0.0 [SPR-12422] #17029

Closed
spring-issuemaster opened this issue Nov 12, 2014 · 6 comments
Closed

Update SockJS client references from 0.3.4 to 1.0.0 [SPR-12422] #17029

spring-issuemaster opened this issue Nov 12, 2014 · 6 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Nov 12, 2014

Sébastien Deleuze opened SPR-12422 and commented

SockJS client 1.0 is likely to be released soon. There is theoretically not much impact on server-side, but we should at least:

  • Test out server-side implementation against this new client release
  • Update the CDN SockJS client URL in AbstractSockJSService
  • Since SSE now supports CORS (see the latest RFC), SockJS client now supports it without IFrames. We should test and eventually update our implementation to support this transport. For example, the EVENT_SOURCE transport should be marked as CORS ready.
  • Update our reference documentation to specify that our implementation has been tested with the 1.0 protocol and clients (in order to avoid potential incompatibilities when SockJS 1.1 or 2.0 will be released)

Reference URL: https://github.com/sockjs/sockjs-client/

Referenced from: commits 79c7e30, a770b15, 6c58258

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 28, 2014

Sébastien Deleuze commented

SockJS 1.0 beta-6 has been released 6 days ago and the changelog seems to show that we are close to the 1.0 release (few small changes in latest beta).

I have contacted Bryce Kahle, the project lead, to know if they plan to release it next week, and if he has identified some remaining changes before the 1.0 release.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Dec 2, 2014

Sébastien Deleuze commented

As discussed during our meeting, I have asked for support of the old protocols_whitelist option in addition to the new transports one, see SockJS client issue #215 for more details.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Dec 26, 2014

Sébastien Deleuze commented

We have no release date for SockJS 1.0, so I have updated the documentation (see this commit) to specify that we support SockJS 0.3.

I have updated this issue target version to 4.2 for the moment. We will reevaluate when SockJS 1.0 will be released if this is relevant to target a 4.1.x release or wait 4.2.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jun 30, 2015

Brian Clozel commented

SockJS 1.0.0 has been released on May 14th.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jun 30, 2015

Sébastien Deleuze commented

Thanks for the notice Brian Clozel !

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 2, 2015

Sébastien Deleuze commented

This commit updates AbstractSockJsService and the reference documentation in order to use SockJS client 1.0.

The spring-origin-test has also been updated to the new client version, and the tests are ok.

The 2 main changes to have in mind :

  • The former protocol_whitelist option has been renamed to transport.
  • A new eventsource transport (without IFrame) is now available, and support cross origin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.