Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAnnotationTransactionAspect retains reference to JpaTransactionManager from closed context [SPR-12518] #17123
Comments
|
Sam Brannen commented
So, thanks for submitting the example project! Please see the Analysis in this issue's updated description for further details. |
|
Sam Brannen commented I'm still pondering what the best solution to this issue is; however, in the meantime I have a work-around for you. In your Gradle build configuration: project.ext {
springVersion = "4.1.2.RELEASE"
// ...
}
// ...
dependencies {
// ...
testCompile "org.springframework:spring-aspects:$springVersion"
// ...
}In @After
public void cleanUpAspects() {
AnnotationTransactionAspect.aspectOf().setTransactionManager(null);
}Let me know if that works for you! Thanks, Sam |
|
Marek Wiącek commented Invoking AnnotationTransactionAspect.aspectOf().setTransactionManager(null) fixes the problem, thank you. |
|
Sam Brannen commented Thanks for providing feedback, Marek! And... I'm glad that work-around fixes the issue for you. :) |
|
Stéphane Nicoll commented We had the same issue with the Cache operation metadata that are .... cached as well. It was only a problem in test really; exactly as in this case. It turns out that we fixed that problem by making the aspect aware that the context has been closed. We can apply the same trick here. |
|
Sam Brannen commented Sounds good! |
|
Stéphane Nicoll commented Applied the same trick as the |
|
Sam Brannen commented Looks Good, Stéphane. Thanks! |
|
Turbanov Andrey commented
|
Marek Wiącek opened SPR-12518 and commented
Original Input From Reporter
@DirtiesContextis broken in 4.1.0:spring-testfails to recreate a context containing a JPAEntityManagerif a test class is annotated with@DirtiesContext(classMode = ClassMode.AFTER_EACH_TEST_METHOD). Interestingly, this only happens in AspectJ mode for@Transactionalsupport.See the attached program to see how to reproduce the problem.
Downgrading the version number in
build.gradleto 4.0.8.RELEASE fixes this problem. Apparently this is a regression introduced in4.1.0.RELEASE.Analysis
The behavior experienced in the example project is a direct result of the caching introduced in #16570.
Specifically, the
determineTransactionManager()method inTransactionAspectSupport(which is a superclass ofAnnotationTransactionAspectwhich in turn provides AspectJ-based support for@Transactionalin Spring) now retains a reference to thePlatformTransactionManager. Since the aspect is a singleton within the class loader, its internal state does not get automatically reset when the application context is closed via@DirtiesContextsemantics.In other words, the testing framework does in fact close the application context due to
@DirtiesContextsemantics, but theAnnotationTransactionAspectretains a reference to theJpaTransactionManagerfrom the closed application context, and that transaction manager in turn retains a reference to the closedEntityManagerFactory. This is evident in the resulting stack trace.Deliverables
Affects: 4.1 GA
Attachments:
Issue Links:
@Configurableobjects should work across test suites@Transactionalqualifier is ignored by TransactionAspectSupport if default transaction manager is setReferenced from: commits ca91956, fd7153f
0 votes, 6 watchers