New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for apache commons-pool2 [SPR-12532] #17137
Comments
Stéphane Nicoll commented Could you please share the configuration that throws that exception? |
Anton Antonov commented Sure. We’re trying to create a pool of (un)marshallers. With Apache Commons Pool 1.6 it works fine, but when we're trying to move to Apache Commons Pool 2.2, we got the issue I mentioned above. Now we’re using Spring 4.0.4, but with Spring 4.1.3 we have the same issue. The reason is that some classes used in Spring AOP was renamed and changed in Apache Common Pool 2.2. Here is our set of beans:
|
Stéphane Nicoll commented As you found out yourself, we don't support commons-pool2 at all. I have started a quick draft of commons pool2 support in a branch. You can give it a try if you want. Let's do this for 4.2 |
Stéphane Nicoll commented Alright, this is implemented. Out of curiosity, what is your use case? Commons pool 1 is now deprecated in favour of the Commons pool 2 support. It should be noted that commons pool 2 has a major semantic difference as it now rely on the object equality for certain things. So holding two different instances that are equals according to I have updated our own support to workaround this. Check the Javadoc for more details. I'd appreciate if you grab a |
Anton Antonov opened SPR-12532 and commented
I've tried to upgrade from commons-pool version 1.6 to commons-pool2 version 2.2 and I got the following exception:
Affects: 4.1.3
Referenced from: commits 5e43f9b, e8441ed, aabf73d
The text was updated successfully, but these errors were encountered: