Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Reference Documentation about Spring WebSocket [SPR-12579] #17180

Closed
spring-issuemaster opened this issue Dec 30, 2014 · 1 comment
Closed
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Dec 30, 2014

Manuel Jordan opened SPR-12579 and commented

I am doing a research about Spring Web Socket. I already have read the current spring reference documentation.

I want ask for an improvement about the following:

  1. Images about better explanation/complement about how work the Destinations and interceptors , it to understand clearly or much better about @MessageMapping and @SubscribeMapping.

The slides available by Rossen about Spring Websocket are nice, they should be included with a detailed explanation on Spring Reference Documentation.

  1. Best suggestion/practice about configure:
registry.enableStompBrokerRelay("/topic", "/queue");
registry.setApplicationDestinationPrefixes("/theapp", "/topic");

For example in the current documentation always appears

registry.setApplicationDestinationPrefixes("/app");

Always one, there is no reason or note about when use other value, how

registry.setApplicationDestinationPrefixes("/app", "/abc");

A sample snippet code with an image would be valuable for a better understanding for a specific scenario

  1. Is not clear if for
registry.enableStompBrokerRelay("/topic", "/queue");

or

registry.enableSimpleBroker("/queue","/topic");

the values of /queue or /topic are mandatory.

If yes, why not consider make available them how constants such the MediaType Class? or like an Enum such as HttpMethod enum?

If not, a sample snippet code with an image would be valuable for a better understanding for a specific scenario.

In the current documentation, I always see /queue or /topic, not other possible values

Thank You


Affects: 4.1.3

Referenced from: commits 6679120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.