Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge default request config with local customizations [SPR-12583] #17184

Closed
spring-issuemaster opened this issue Dec 31, 2014 · 0 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Dec 31, 2014

Stéphane Nicoll opened SPR-12583 and commented

Before #17144, only the local customizations on the factory were available to each request and the defaults of the client were always ignored.

If the factory is defined with HttpClient, its default settings are taken into account as long as no local customizations are made. Therefore, all customizations should be set in the created client.

We can do better as from HttpComponents 4.4 since the default config of the HttpClient can be accessed. In that case we can retrieve that config and merge it with our local customizations instead of overriding everything else.


Issue Links:

  • #17144 Configured RequestConfig in HttpClient gets overwritten by default
  • #17423 HttpComponentsClientHttpRequestFactory should not depend on CloseableHttpClient

Referenced from: commits bce145c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.