Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review MBean related performance tests [SPR-12601] #17202

Closed
spring-issuemaster opened this issue Jan 7, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jan 7, 2015

Stéphane Nicoll opened SPR-12601 and commented

Our performance job on CI is failing sometimes on the following tests:

MBeanClientInterceptorTests testTestLazyConnectionToRemote	Default Job
RemoteMBeanClientInterceptorTests testSetAttributeValueWithRuntimeException	Default Job
RemoteMBeanClientInterceptorTests testSetAttributeValue	Default Job
RemoteMBeanClientInterceptorTests testInvokeNoArgs	Default Job
RemoteMBeanClientInterceptorTests testSetReadOnlyAttribute	Default Job
RemoteMBeanClientInterceptorTests testInvokeUnexposedMethodWithException	Default Job
RemoteMBeanClientInterceptorTests testTestLazyConnectionToRemote	Default Job
RemoteMBeanClientInterceptorTests testSetAttributeValueWithIOException	Default Job
RemoteMBeanClientInterceptorTests testGetAttributeValue	Default Job
RemoteMBeanClientInterceptorTests testDifferentProxiesSameClass	Default Job
RemoteMBeanClientInterceptorTests testSetAttributeValueWithCheckedException	Default Job
RemoteMBeanClientInterceptorTests testProxyClassIsDifferent	Default Job
RemoteMBeanClientInterceptorTests testInvokeArgs	Default Job
ConnectorServerFactoryBeanTests testNoRegisterWithMBeanServer	Default Job
ConnectorServerFactoryBeanTests testRegisterWithMBeanServer	Default Job
ConnectorServerFactoryBeanTests testStartupWithSuppliedServer	Default Job
ConnectorServerFactoryBeanTests testStartupWithLocatedServer	Default Job
MBeanServerConnectionFactoryBeanTests testTestWithLazyConnection	Default Job
MBeanServerConnectionFactoryBeanTests testTestValidConnection

Issue Links:

  • #15289 Install jmxremote_optional.jar in Java 8 JVM used for Spring performance builds
@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 12, 2015

Sam Brannen commented

After copying jmxremote_optional.jar to jre/lib/ext in my local JDK 8 installation, the aforementioned tests pass on my Mac.

In addition, I made the following improvements as described in GitHub commit 7a6dfe3:

Make MBeanServer integration tests more robust

This commit overhauls several of the tests that interact with an
MBeanServer with the goal of increasing the reliability of these tests.

  • MBeanClientInterceptorTests now uses JUnit "assumptions" instead of
    preemptively returning from test methods, thus allowing such methods
    to be properly marked as "ignored" instead of "passed".

  • MBeanClientInterceptorTests now uses JUnit's support for expected
    exceptions where appropriate.

  • MBeanClientInterceptorTests and RemoteMBeanClientInterceptorTests now
    use Spring's SocketUtils to find an available TCP port when starting
    an MBeanServer instead of aborting the tests when the default JMX
    port is not available.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 12, 2015

Stéphane Nicoll commented

Thanks Sam!

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 12, 2015

Sam Brannen commented

Prego! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.