Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow readTimeout / connectTimeout in Netty4ClientHttpRequestFactory [SPR-12612] #17213

Closed
spring-issuemaster opened this issue Jan 10, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jan 10, 2015

Francisco Lozano opened SPR-12612 and commented

In older ClientHttpRequestFactory's (java native and in Apache HTTP components) it is possible to declare readTimeout and connectTimeout.

Netty4ClientHttpRequestFactory doesn't allow this.

Connect timeout looks straightforward: it can be easily implemented in ChannelConfig (http://netty.io/4.0/api/io/netty/channel/ChannelConfig.html).

Read timeout could be implemented with a timeout handler in the pipeline (http://netty.io/4.0/api/io/netty/handler/timeout/ReadTimeoutHandler.html). I'm not sure about this one however - the timeout should affect only when waiting for an HTTP request.


Affects: 4.1.4

Referenced from: commits e24ebd6

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 27, 2015

Arjen Poutsma commented

PR at #749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.