Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting method in SimpleBrokerMessageHandlerTests not asserting anything [SPR-12615] #17216

Closed
spring-issuemaster opened this issue Jan 11, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jan 11, 2015

Ralph Schaer opened SPR-12615 and commented

The return value of the method org.springframework.messaging.simp.broker.SimpleBrokerMessageHandlerTests#assertCapturedMessage is never checked.
So it never asserts the captured messages

There are two wrong expected assert messages (assertEquals("Expected .....) in this unit test
org.springframework.messaging.simp.broker.DefaultSubscriptionRegistryTests

Line 269: Should be "two" instead of "three"
Line 313: Should be "one" instead of "three"


Affects: 4.1.4

Reference URL: https://github.com/spring-projects/spring-framework/blob/master/spring-messaging/src/test/java/org/springframework/messaging/simp/broker/SimpleBrokerMessageHandlerTests.java

Referenced from: commits 497944f, 84807c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.