Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken schedulerWithHsqlDataSource() test in QuartzSupportTests [SPR-12618] #17219

Closed
spring-issuemaster opened this issue Jan 11, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jan 11, 2015

Sam Brannen opened SPR-12618 and commented

Status Quo

Changes made in GitHub commit b43fc7a caused the schedulerWithHsqlDataSource() test in QuartzSupportTests to start failing.

Specifically, this test has been failing during Performance Builds since build #297.

Assumptions

Since the commit in question upgraded the Quartz version, one could assume that it is necessary to upgrade the quartz-hsql.sql file (as was done in the fix for #16253); however, an initial attempt at this did not seem to resolve the problem. Thus further analysis is required.

Deliverables

  1. Determine why schedulerWithHsqlDataSource() is failing after an upgrade to Quartz 2.2.1 and refactor tests and related configuration to ensure that all tests pass during Spring's Performance builds.

Affects: 4.1 GA

Issue Links:

  • #16253 Fix broken tests in QuartzSupportTests

Referenced from: commits 49e31c3, b82e9c4

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 21, 2015

Juergen Hoeller commented

Fixed through reducing the test to the trigger table check, not bothering with waiting for the job executing anymore.

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 21, 2015

Sam Brannen commented

Thanks, Juergen!

Looking forward to a green Performance build tonight... the first one in a looooong time. ;)

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 21, 2015

Stéphane Nicoll commented

dito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.