Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error in "SimpleJdbcInsert" section [SPR-12639] #17240

Closed
spring-issuemaster opened this issue Jan 18, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jan 18, 2015

Mithun Gooty opened SPR-12639 and commented

Section where the issue is identified:
14.5.2 Retrieving auto-generated keys using SimpleJdbcInsert

There is an explanation about the sample code to demonstrate SimpleJdbcInsert. In this section, the method name is wrongly documented. It should be changed from "executeReturningKey" to "executeAndReturnKey".


Reference URL: http://docs.spring.io/spring/docs/current/spring-framework-reference/html/jdbc.html#jdbc-simple-jdbc-insert-2

Backported to: 3.2.14

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 19, 2015

Mithun Gooty commented

Could you please let me know if I Can pick up this task for fixing the documentation?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 19, 2015

Stéphane Nicoll commented

Sure, a pull request is more than welcome. Check the contributing page for more details.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 20, 2015

Mithun Gooty commented

I have made the changes in the documentation. Please find the pull request below:

#722

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 22, 2015

Stéphane Nicoll commented

Merged, thanks! Also backported to 4.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.