Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow YamlProcessor subclasses to provide the Yaml instance that's used [SPR-12671] #17270

Closed
spring-issuemaster opened this issue Jan 29, 2015 · 3 comments

Comments

@spring-issuemaster
Copy link
Collaborator

commented Jan 29, 2015

Andy Wilkinson opened SPR-12671 and commented

By default, SnakeYAML will turn a timestamp-like string into a java.util.Date. To disable this behaviour a Yaml instance has to be created with a custom Resolver. I'd like to be able to use YamlProcessor with such a Yaml instance but YamlProcessor doesn't make it easy to do so. Currently I'd have to override process(MatchCallback) and duplicate its logic. I'd also have to duplicate StrictMapAppenderConstructor as it's declared private preventing me from using it when I create my own Yaml instance.


Affects: 4.1.4

Reference URL: spring-projects/spring-boot#2422

Referenced from: commits d8cec85, 6fce6d4

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 29, 2015

Stéphane Nicoll commented

I am assuming you need that change in the 4.1.x line as well.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 29, 2015

Andy Wilkinson commented

Yes, please. I was just looking at the ugly override approach and it's not really practical as there's no (easy) way to get at resources or resolutionMode so I think the Boot issue's really blocked by this issue.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 2, 2015

Stéphane Nicoll commented

Alright, I added a hook point. Available in both master and 4.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.