Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MBeanExporter's excludedBeans to be configured additively [SPR-12686] #17285

Closed
spring-issuemaster opened this issue Feb 4, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Feb 4, 2015

Andy Wilkinson opened SPR-12686 and commented

MBeanExporter currently only provides a setter for its set of excluded bean names. In Spring Boot we'd like to be able to collect the excluded bean names in an additive fashion as we process an application's (auto-)configuration. I'm envisaging being able to do something like this:

@Autowired(required = false)
private MBeanExporter mBeanExporter;

@Bean(destroyMethod = "")
@ConditionalOnMissingBean
public DataSource dataSource(DataSourceProperties properties) {
    if (this.mBeanExporter != null) {
        this.mBeanExporter.addExcludedBean("dataSource");
    }
    JndiDataSourceLookup dataSourceLookup = new JndiDataSourceLookup();
    return dataSourceLookup.getDataSource(properties.getJndiName());
}

Affects: 4.1.4

Reference URL: spring-projects/spring-boot#2397

Referenced from: commits 982f9ce, 09bd703

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 9, 2015

Stéphane Nicoll commented

addExcludedBean has been added on MbeanExporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.