Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled websocket error when unsolicited pong frame with zero length payload received from IE11 [SPR-12727] #17324

Closed
spring-issuemaster opened this issue Feb 18, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Feb 18, 2015

Mark Anderson opened SPR-12727 and commented

An unhandled error occurs when an unsolicited pong frame with zero length payload is received from IE11. I'm using Spring Framework 4.1.4 and Jetty 9.2.6.

It seems that Jetty returns a null payload when an unsolicited pong frame is received and Spring cannot handle this.

WARN  Feb 18 10:54:50 (328489 [qtp300104620-117] org.springframework.web.socket.adapter.jetty.JettyWebSocketHandlerAdapter) Unhandled Error (closing connection)
     [java] org.eclipse.jetty.websocket.api.WebSocketException: Cannot call method public void org.springframework.web.socket.adapter.jetty.JettyWebSocketHandlerAdapter#onWebSocketFrame(org.eclipse.jetty.websocket.api.extensions.Frame) with args: [org.eclipse.jetty.websocket.common.frames.PongFrame]
     [java] 	at org.eclipse.jetty.websocket.common.events.annotated.CallableMethod.call(CallableMethod.java:99)
     [java] 	at org.eclipse.jetty.websocket.common.events.annotated.OptionalSessionCallableMethod.call(OptionalSessionCallableMethod.java:72)
     [java] 	at org.eclipse.jetty.websocket.common.events.JettyAnnotatedEventDriver.onFrame(JettyAnnotatedEventDriver.java:149)
     [java] 	at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:107)
     [java] 	at org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
     [java] 	at org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
     [java] 	at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
     [java] 	at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
     [java] 	at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:613)
     [java] 	at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:468)
     [java] 	at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)
     [java] 	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:626)
     [java] 	at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:546)
     [java] 	at java.lang.Thread.run(Thread.java:745)
     [java] Caused by: java.lang.reflect.InvocationTargetException
     [java] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [java] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [java] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [java] 	at java.lang.reflect.Method.invoke(Method.java:483)
     [java] 	at org.eclipse.jetty.websocket.common.events.annotated.CallableMethod.call(CallableMethod.java:71)
     [java] 	... 13 more
     [java] Caused by: java.lang.IllegalArgumentException: payload must not be null
     [java] 	at org.springframework.util.Assert.notNull(Assert.java:112)
     [java] 	at org.springframework.web.socket.AbstractWebSocketMessage.<init>(AbstractWebSocketMessage.java:52)
     [java] 	at org.springframework.web.socket.AbstractWebSocketMessage.<init>(AbstractWebSocketMessage.java:40)
     [java] 	at org.springframework.web.socket.PongMessage.<init>(PongMessage.java:41)
     [java] 	at org.springframework.web.socket.adapter.jetty.JettyWebSocketHandlerAdapter.onWebSocketFrame(JettyWebSocketHandlerAdapter.java:99)
     [java] 	... 18 more


Affects: 4.1.4

Issue Links:

  • #17325 Stomp error when PongMessage is passed to StompSubProtocolHandler
@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 18, 2015

Rossen Stoyanchev commented

This should now be resolved with commit f1e406.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.