Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider lowering EventListenerMethodProcessor log levels [SPR-12754] #17351

Closed
spring-issuemaster opened this issue Feb 25, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Feb 25, 2015

Gary Russell opened SPR-12754 and commented

Consider lowering this

https://github.com/spring-projects/spring-framework/blob/master/spring-context/src/main/java/org/springframework/context/event/EventListenerMethodProcessor.java#L132

to TRACE level.

I see a lot of pollution in debug logs (with large contexts).


Affects: 4.2 RC1

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 25, 2015

Juergen Hoeller commented

Or we could simply drop that log entry completely... After all, we're only really interested in methods which actually have an event listener role.

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 25, 2015

Stéphane Nicoll commented

Note that this code comes from an harmonization polish and other BPP are affected by the same issue. Juergen, should I go ahead and update those as well?

I'd keep the trace level though: if someone wants to understand why the event is not fired, this might be a good way (weird proxy setup preventing the annotation to be found).

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 26, 2015

Juergen Hoeller commented

Alright, makes sense to consistently apply trace logging then...

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 26, 2015

Stéphane Nicoll commented

Reduced to TRACE and applied consistently for @Scheduled and @JmsListener.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.