Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build to Gradle 2.4 [SPR-12772] #17369

Closed
spring-projects-issues opened this issue Mar 1, 2015 · 8 comments
Closed

Upgrade build to Gradle 2.4 [SPR-12772] #17369

spring-projects-issues opened this issue Mar 1, 2015 · 8 comments
Assignees
Labels
type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Mar 1, 2015

Sam Brannen opened SPR-12772 and commented

Tweets and Blogs about Gradle 2.4


Affects: 4.2 RC1

Issue Links:

  • #16551 Upgrade build to Gradle 2.2.1 ("depends on")
  • #17603 Upgrade build to Gradle 2.5 for JDK 9 support

Referenced from: commits ed60b8c

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 6, 2015

Sam Brannen commented

Upgraded to Gradle 2.4 in GitHub commit ed60b8c.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 7, 2015

Juergen Hoeller commented

It seems we lost our ability to build on JDK 9? I get a "Could not find tools.jar" out of the Gradle compiler abstraction when executing the build on JDK 9 now...

Juergen

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 7, 2015

Sam Brannen commented

Hmmmmm.... yeah, you're right: it fails for me on JDK 9 as well. :(

I'll look into it.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 7, 2015

Sam Brannen commented

Reopening in order to investigate compatibility issues with JDK 9.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 7, 2015

Juergen Hoeller commented

We may also decide that it's ok for our build to only work on JDK 8 for the time being... if Gradle 2.4 provides enough advantage to us.

We also have AspectJ 1.9 beta 1 in our setup just for the ability to build on JDK 9. It's not unfeasible to give up on that for Spring 4.2, just aiming for JDK 9 builds in our 4.3 line.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 8, 2015

Sam Brannen commented

OK, Juergen Hoeller, I am marking this issue as resolved again since developers do in fact experience 30% faster builds.

Regarding support for JDK 9 with Gradle 2.4.x, I have raised an issue on the Gradle Forum.

Regards,

Sam

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 8, 2015

Sam Brannen commented

Please keep in mind that it is always possible to downgrade to Gradle 2.2.1 locally for intermittent testing against JDK 9. So we still have the option of testing against JDK 9 when we need to, but the default will be to build against JDK 8 and Gradle 2.4

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 11, 2015

Sam Brannen commented

Update: Gradle 2.5 will officially support JDK 9.

In fact, the Gradle 2.5 nightly build already supports building spring-test (and presumably the rest of the spring-framework) against JDK 9.

For details, see the comments from Adrian Kelly on the Gradle Forums.

See also: #17603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task
Projects
None yet
Development

No branches or pull requests

2 participants