Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not reusable input stream in ContentCachingRequestWrapper [SPR-12810] #17407

Closed
spring-issuemaster opened this issue Mar 12, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Mar 12, 2015

Vlad Bochenin opened SPR-12810 and commented

in org/springframework/web/util/ContentCachingRequestWrapper.java

When you call getParameterMap(), Tomcat, for example, reads parameters from InputStream, so impossible to read from input stream in servlet

I tried in Tomcat 7.0.52, but I think it will be reproduced in other servlet containers

Step to reproduce

  1. Register logging filter (CommonsRequestLogginFilter etc) in filter chain
  2. Execute POST Form request
  3. Try to read something from request input stream in servlet (after filter was executed)

Expected result:
you can read data from input stream

Actual Result:
You cannot read any data from input stream


Affects: 4.1.5

Issue Links:

  • #17412 Improve ContentCachingRequestWrapper

Referenced from: commits 151e96c, abd7052, ce84faf, c6250f5

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 12, 2015

Brian Clozel commented

Could you elaborate?
How can I reproduce this? What's the expected behavior, the actual behavior?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 12, 2015

Brian Clozel commented

Thanks for taking the time to update the description Vlad Bochenin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.