Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockHttpServletRequestBuilder should not decode query string [SPR-12880] #17478

Closed
spring-issuemaster opened this issue Apr 2, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Apr 2, 2015

Arien Kock opened SPR-12880 and commented

While testing I discovered that (per the spec) HttpServletRequest.getQueryString() should not be decoded. In fact, it is not when the web application is deployed to Jetty.

Excerpt from the Javadoc for HttpServletRequest.getQueryString():

Returns: a String containing the query string or null if the URL contains no query string. The value is not decoded by the container.

However, MockHttpServletRequestBuilder decodes the queryString when building. Thus, I believe this is a defect in MockHttpServletRequestBuilder.


Affects: 4.1.6

Referenced from: commits 0b8554f

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 3, 2015

Rossen Stoyanchev commented

This looks like an issue indeed, on that has been there from the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.