Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No handling for a single | [SPR-12952] #17544

Closed
spring-projects-issues opened this issue Apr 24, 2015 · 3 comments
Closed

No handling for a single | [SPR-12952] #17544

spring-projects-issues opened this issue Apr 24, 2015 · 3 comments
Assignees
Labels
in: core

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Apr 24, 2015

Igors Ustinovs opened SPR-12952 and commented

Specifying OR operator as a single | instead of || causes the system to hang


Affects: 3.2 GA

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 24, 2015

Juergen Hoeller commented

As far as I can tell, we simply don't support the single '|' operator in SpEL. In my local unit tests, I get a proper exception for such a scenario. Do you have a specific SpEL expression that causes it to hang?

Juergen

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 24, 2015

Igors Ustinovs commented

Please see the trace below. Test expression is simply "|" or in fact any containing a single "|".
The method seems to fall into never-ending loop after that

at org.springframework.expression.spel.standard.Tokenizer.process(Tokenizer.java:145)
at org.springframework.expression.spel.standard.Tokenizer.<init>(Tokenizer.java:47)
at org.springframework.expression.spel.standard.InternalSpelExpressionParser.doParseExpression(InternalSpelExpressionParser.java:77)
at org.springframework.expression.spel.standard.SpelExpressionParser.doParseExpression(SpelExpressionParser.java:56)
at org.springframework.expression.spel.standard.SpelExpressionParser.doParseExpression(SpelExpressionParser.java:32)
at org.springframework.expression.common.TemplateAwareExpressionParser.parseExpression(TemplateAwareExpressionParser.java:66)
at org.springframework.expression.common.TemplateAwareExpressionParser.parseExpression(TemplateAwareExpressionParser.java:56)

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Apr 24, 2015

Juergen Hoeller commented

I can't reproduce this against 4.x, so it may be a 3.2.x only issue (which we're unlikely to fix at this point). Could you give it a try against 4.1.6 please?

Juergen

@spring-projects-issues spring-projects-issues added type: bug in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues removed the type: bug label Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core
Projects
None yet
Development

No branches or pull requests

2 participants