Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Future responses in caching annotations [SPR-12967] #17559

Closed
spring-issuemaster opened this issue Apr 30, 2015 · 3 comments
Closed

Support for Future responses in caching annotations [SPR-12967] #17559

spring-issuemaster opened this issue Apr 30, 2015 · 3 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 30, 2015

Lukas Krecan opened SPR-12967 and commented

It would be nice to support caching of ListenableFuture (CompletableFuture) results. Imagine that your method returns ListenableFuture and you want to cache the result (not the future itself). If I am not mistaken it is not currently supported.

I may send you a pull request, but I'd like to hear if it makes sense. It may be a bit confusing since the cache would be filled/evicted not upon the method exit but upon the future completion.


Affects: 4.1.6

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 5, 2015

Lukas Krecan commented

Hint of the solution lukas-krecan@48329ff

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 15, 2015

Stéphane Nicoll commented

We don't foresee such feature in the 4.x line as it sounds it's part of a more general reactive effort.

Looking at your proposal it has significant impacts on the boundaries and the semantics of the caching aspect (basically what happens when we exit the method vs. what happens when the value to cache is actually made available). JSR-107 has also some plans to add an asynchronous API (see this issue) so this request may benefit from that stuff.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 12, 2019

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.