Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AntPathMatcher should throw an IllegalArgumentException if patterns cannot be combined [SPR-12998] #17590

Closed
spring-issuemaster opened this issue May 8, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented May 8, 2015

Sam Brannen opened SPR-12998 and commented

Status Quo

The Javadoc for the combine(String, String) method in AntPathMatcher states that it will thrown an IllegalArgumentException if the two patterns cannot be combined. However, the following simply returns "/*.html" (i.e., pattern1) instead of throwing an exception.

pathMatcher.combine("/*.html", "/*.txt");

Deliverables

  1. Ensure that combine(String, String) properly throws an exception if the supplied patterns cannot be properly combined.
    • Enable the combineWithTwoFileExtensionPatterns() test case in AntPathMatcherTests by deleting the @Ignore declaration.

No further details from SPR-12998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.