Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DispatcherServlet diagrams [SPR-13120] #17711

Closed
spring-issuemaster opened this issue Jun 12, 2015 · 4 comments
Closed

Improve DispatcherServlet diagrams [SPR-13120] #17711

spring-issuemaster opened this issue Jun 12, 2015 · 4 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Jun 12, 2015

Jesus Calimlim Angeles Jr. opened SPR-13120 and commented

The Figure in "Figure 17.2. Context hierarchy in Spring Web MVC" can be improved.

  1. What is the significance of the blue two-headed arrows? Does it mean anything?
  2. Why is the "WebApplicationContext(s)" having an "(s)"? It is the root application context if I am not wrong. There is only 1 if I am not wrong.
  3. Why is the box of "WebApplicationContext(s)" showing multiple boxes? Does it represent multiple XML files forming one context? If so, it is not important to put it so, as any context is understood to possibly come from multiple XML files (or java config, etc.).

Affects: 4.1.6

Reference URL: http://docs.spring.io/spring-framework/docs/4.1.6.RELEASE/spring-framework-reference/html/images/mvc-contexts.gif

Referenced from: commits df9290c

0 votes, 5 watchers

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jun 15, 2015

Rossen Stoyanchev commented

The blue arrows look like they represent the steps including invocation and what's being returned from each participant. As for the multiple "root" WebApplicationContexts, I believe in most cases it should be one context but there are some cases with EAR deployment where there can be a parent of the root context. Assuming I am correct we should simplify the diagram a bit.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 9, 2015

Sébastien Deleuze commented

I have simplified the diagram and added another one for the "single root context" use case.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 9, 2015

Brian Clozel commented

Much better!

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 9, 2015

Jesus Calimlim Angeles Jr. commented

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.