New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require JUnit 4.12 or higher in the TestContext framework [SPR-13275] #17866

Closed
spring-issuemaster opened this Issue Jul 24, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Jul 24, 2015

Juergen Hoeller opened SPR-13275 and commented

JUnit 4.12 was released in December 2014. We should make it required as of Spring Framework 4.3, getting rid of deprecated calls in SpringJUnit4ClassRunner.


Issue Links:

  • #17116 Upgrade to JUnit 4.12
  • #16527 Require JUnit 4.9 or higher in the TestContext framework
  • SEC-3178 Update to junit-4.12

Referenced from: commits 66562f2

0 votes, 5 watchers

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Dec 18, 2015

Juergen Hoeller commented

Sam Brannen, please roll this into master rather soon, in order for our general baseline upgrade to be completed...

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Dec 18, 2015

Sam Brannen commented

OK. I should be able to take care of that before the end of the year (likely before Christmas).

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Dec 19, 2015

Sam Brannen commented

Pushed to master in:

66562f2

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Dec 21, 2015

Juergen Hoeller commented

Rob Winch, I hope this is not as much of an issue as the Tiles 2 stuff? We're raising to JUnit 4.12+ primarily for forward compatibility with JUnit 4.13 (scheduled for 2016) and future versions where the previously used deprecated methods might not be there anymore...

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Dec 21, 2015

Rob Winch commented

Juergen Hoeller Thanks for checking. For Spring Security this was as easy as updating the junit version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment