Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generics and caching causing issues [SPR-13358] #17942

Closed
spring-issuemaster opened this issue Aug 17, 2015 · 1 comment
Closed

Generics and caching causing issues [SPR-13358] #17942

spring-issuemaster opened this issue Aug 17, 2015 · 1 comment
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Aug 17, 2015

Abdul Rahim Suriya opened SPR-13358 and commented

The LazyParamAwareEvaluationContext caches the java.lang.reflect.Method instance on which the Caching annotations are present against a (programmatically generated) method signature.

This causes issue with generics in an interface hierarchy. If not a fix in the code, a documentation update should help in warning under certain circumstances. In fact the default recommendation can be to use the #root.args[] or #a0, #p0 for referring to method parameters rather than by name (which would also not be available in cases where compilation step did not include debug information)

The referenced github project is a sample that helps reproduce the issue and also provides recommendation for the fix in such scenario.


Affects: 3.2.14

Reference URL: https://github.com/arsuriya/spring-caching-generics

Issue Links:

  • #14159 The expression language used in cache annotations can be error prone when referencing explict parameter names
@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jan 19, 2016

Stéphane Nicoll commented

Please upgrade as this is fixed since Spring Framework 4.0.4.RELEASE and later (see #16314)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.