Support @CrossOrigin as a merged composed annotation [SPR-13468]

[spring-projects-issues]

Nicolas Labrot opened SPR-13468 and commented

Given this composed annotation:

@Target({ElementType.METHOD, ElementType.TYPE})
@Retention(RetentionPolicy.RUNTIME)
@Documented
@RequestMapping
@CrossOrigin
@ResponseBody
public @interface CorsRequestMapping {
    String[] path() default {};
    String[] origins() default {};
    RequestMethod[] method() default {};
}

The resulting @CrossOrigin "origins" attribute is not merged. Issue seems to come from RequestMappingHandlerMapping#initCorsConfiguration which does not use AnnotatedElementUtils.findMergedAnnotation(*, CrossOrigin.class);.

---

Affects: 4.2 GA

Issue Links:

• #18022 Introduce predefined composed annotations in core Spring
• #18020 Use AnnotatedElementUtils instead of AnnotationUtils wherever feasible
• #18021 Support @ResponseStatus as a merged composed annotation
• #18054 Support @Cache* as merged composed annotations

Referenced from: commits e4c0859, 0ad59dd

0 votes, 5 watchers

[spring-projects-issues]

Nicolas Labrot commented

I have submitted a PR for this issue:
#877

[spring-projects-issues]

Sam Brannen commented

Completed in GitHub commit 0ad59dd.