Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractEmbeddedDatabaseConfigurer.shutdown does not close JDBC resources [SPR-13474] #18053

Closed
spring-projects-issues opened this issue Sep 19, 2015 · 1 comment
Assignees
Labels
in: data status: backported type: bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Sep 19, 2015

Jimmy Praet opened SPR-13474 and commented

AbstractEmbeddedDatabaseConfigurer.shutdown opens a JDBC connection to issue a SHUTDOWN command to the database, but does not close this connection.

It might seem unnecessary at first sight to close this connection, as we are shutting down the database anyway. However, for H2 this unclosed connection is triggering its keepOpenStacktrace logging modus. From that point on, it will generate a stacktrace for each opened connection, which is quite costly.


Affects: 3.2.14, 4.1.7, 4.2.1

Referenced from: commits 51a0237, b23c232, aa0f117

Backported to: 4.1.8, 3.2.15

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 21, 2015

Juergen Hoeller commented

Thanks for the report! As of 4.2.2 and 4.1.8, we're explicitly closing that JDBC Connection for the shutdown statement (which should be entirely sufficient and won't create serious side effects).

To be backported to 3.2.15 as well, whenever that one happens.

Juergen

@spring-projects-issues spring-projects-issues added type: bug in: data status: backported labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.2.2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data status: backported type: bug
Projects
None yet
Development

No branches or pull requests

2 participants