Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation about CookieLocaleResolver vs SessionLocaleResolver [SPR-13505] #18083

Closed
spring-issuemaster opened this issue Sep 24, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Sep 24, 2015

Manuel Jordan opened SPR-13505 and commented

Hello

In the Reference Documentation, for the section "21.8. Using locales"
Where I can see the sub sections:

21.8.4. SessionLocaleResolver
21.8.5. LocaleChangeInterceptor

Just curious if is possible add a note about when use each approach, advantages and disadvantages for each one.

If exists some relation or impact about "SessionLocaleResolver" for Spring Session and Spring Cloud.

Thanks.


Affects: 4.2 GA

Referenced from: commits 6d36930

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 27, 2015

Juergen Hoeller commented

I've added a note on SessionLocaleResolver: In contrast to CookieLocaleResolver, this strategy stores locally chosen locale settings in the Servlet container's HttpSession. As a consequence, those settings are just temporary for each session and therefore lost when each session terminates.

There is no direct relationship with Spring Session. Our SessionLocaleResolver will simply evaluate and modify corresponding HttpSession attributes against the current HttpServletRequest.

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 27, 2015

Manuel Jordan commented

Hi Juergen

Thanks by the valuable explanation. I think your two paragraphs should be added in the Reference Documentation. As well how in the API too.

Kind Regards

-Manuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.