Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining JUnit 3 based tests to JUnit 4 [SPR-13514] #18091

Closed
2 tasks done
spring-projects-issues opened this issue Sep 27, 2015 · 1 comment
Closed
2 tasks done
Assignees
Labels
type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Sep 27, 2015

Sam Brannen opened SPR-13514 and commented

Status Quo

JUnit 4.0 was released almost a decade ago; however, there are still numerous test classes in Spring's own test suite that are based on the legacy JUnit 3 programming model and APIs.

In preparation for the upcoming JUnit 5 (a.k.a., JUnit Lambda) release we should therefore proactively migrate our test suite completely to the JUnit 4 programming model.

Deliverables

  1. Migrate existing JUnit 3 based tests to JUnit 4.
  2. Migrate Spring's legacy testing framework -- which is still used internally within the spring-orm module -- to JUnit 4.
    • This action has not been performed due to challenges resulting from the use of a ShadowingClassLoader in AbstractJpaTests.
    • To be addressed in #18092.

Affects: 4.2 GA

Issue Links:

  • #20449 SimpleAsyncTaskExecutor not respect ConcurrencyThrottleSupport.NO_CONCURRENCY limit
  • #18151 Introduce support for JUnit 5 in the TestContext framework
  • #18092 Remove AbstractJpaTests and revise spring-orm test suite accordingly
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 27, 2015

Sam Brannen commented

Work performed in GitHub commit d5ee787:

Migrate JUnit 3 tests to JUnit 4

This commit migrates all remaining tests from JUnit 3 to JUnit 4, with the exception of Spring's legacy JUnit 3.8 based testing framework that is still in use in the spring-orm module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task
Projects
None yet
Development

No branches or pull requests

2 participants