Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AbstractJpaTests and revise spring-orm test suite accordingly [SPR-13515] #18092

Closed
spring-projects-issues opened this issue Sep 27, 2015 · 1 comment
Assignees
Labels
in: data in: test type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Sep 27, 2015

Sam Brannen opened SPR-13515 and commented

Status Quo

Except for Spring's legacy JUnit 3.8 based testing framework which is still used internally within the spring-orm module, the Spring test suite was completely migrated to the JUnit 4 programming model in conjunction with #18091.

The reason the legacy testing framework is still based on JUnit 3.8 is that AbstractJpaTests uses a ShadowingClassLoader to load and execute the test in a different class loader.

Unfortunately, it is impossible to achieve the same results without introducing a custom JUnit Runner.

Possible Solutions

  1. Introduce a custom Runner that reproduces the behavior in AbstractJpaTests.
  2. Migrate the concrete subclasses of AbstractJpaTests to JUnit 4 without the use of a ShadowingClassLoader.

Deliverables

  1. Remove AbstractJpaTests along with the remainder of the legacy JUnit 3.8 based testing framework in the spring-orm module.
  2. Revise all concrete subclasses of AbstractJpaTests accordingly.

Affects: 4.2 GA

Issue Links:

  • #17778 Upgrade core framework build to JDK 11 ("is depended on by")
  • #18091 Migrate remaining JUnit 3 based tests to JUnit 4
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 28, 2015

Juergen Hoeller commented

Currently planned for 5.0 where we'll raise to a JPA 2.1 baseline and have to redo the JPA tests in any case, potentially even dropping the OpenJPA tests completely (due to OpenJPA's inactivity towards JPA 2.1).

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data in: test type: task
Projects
None yet
Development

No branches or pull requests

2 participants