Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with GlassFish 4.1.1 / Tyrus 1.12 [SPR-13566] #18142

Closed
spring-projects-issues opened this issue Oct 13, 2015 · 4 comments
Closed

Compatibility with GlassFish 4.1.1 / Tyrus 1.12 [SPR-13566] #18142

spring-projects-issues opened this issue Oct 13, 2015 · 4 comments
Assignees
Labels
status: backported type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 13, 2015

Juergen Hoeller opened SPR-13566 and commented

GlassFish 4.1.1 got released in September, updating plenty of components - including Tyrus. Let's make sure that our WebSocket support works fine, and that we're generally compatible with it.


Affects: 4.1.7, 4.2.1

Issue Links:

  • #18073 Require Undertow 1.3.5+, Tyrus 1.11+, Jetty 9.3+, Tomcat 8.5+ ("is depended on by")
  • #17825 Compatibility with WebLogic 12.2.1 / Tyrus 1.11

Backported to: 4.1.8

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 13, 2015

Brian Clozel commented

Resolved with a small update, due to changes in TyrusEndpointWrapper's constructor signature.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 13, 2015

Juergen Hoeller commented

I'm backporting this to 4.1.8 as well... After all, GlassFish 4.1.1 is just a maintenance release, Spring 4.1.x really should keep working there.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 13, 2015

Brian Clozel commented

Great, thanks!
Don't forget to backport the whole thing (two commits to be merged into one), since I didn't see that Constructor.getParameterCount was JDK8+ (it has no @since documentation on it).

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 13, 2015

Juergen Hoeller commented

I've backported it in a slightly optimized fashion. I'll align master in just a bit.

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: backported type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants