Support Spring-WS's MessageDispatcherServlet in AbstractDispatcherServletInitializer [SPR-13616]

[spring-projects-issues]

Kamill Sokol opened SPR-13616 and commented

Problem:
Right now we have to override AbstractDispatcherServletInitializer.registerDispatcherServlet(...) in order to register Spring-WS's MessageDispatcherServlet (tested with Version 2.2.0.RELEASE). AbstractDispatcherServletInitializer.registerDispatcherServlet(...) calls createDispatcherServlet which returns a DispatcherServlet instance whereas MessageDispatcherServlet directly derives from FrameworkServlet. Both DispatcherServlet and MessageDispatcherServlet have the same base class in common that said FrameworkServlet.

Solution:
AbstractDispatcherServletInitializer.registerDispatcherServlet(...) should return FrameworkServlet in order to support both Spring MVC's DispatcherServlet and Spring-WS's MessageDispatcherServlet.

A pull request with a fix will be provided via Github.

---

Affects: 4.2.2

Referenced from: commits c1c07bb

[spring-projects-issues]

Juergen Hoeller commented

Good point - relaxing createDispatcherServlet's declared return type should even be binary-compatible for overriding due to the way covariant return types work. I'll apply this right away with some fine-tuning of the corresponding javadoc.

Juergen