Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport Spring-WS's MessageDispatcherServlet in AbstractDispatcherServletInitializer [SPR-13616] #18194
Comments
This comment has been minimized.
This comment has been minimized.
Juergen Hoeller commented Good point - relaxing Juergen |
spring-issuemaster
closed this
Nov 15, 2015
spring-issuemaster
added
type: enhancement
in: core
labels
Jan 11, 2019
spring-issuemaster
added this to the 4.2.3 milestone
Jan 11, 2019
spring-issuemaster
assigned
jhoeller
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
spring-issuemaster commentedOct 27, 2015
Kamill Sokol opened SPR-13616 and commented
Problem:
Right now we have to override AbstractDispatcherServletInitializer.registerDispatcherServlet(...) in order to register Spring-WS's MessageDispatcherServlet (tested with Version 2.2.0.RELEASE). AbstractDispatcherServletInitializer.registerDispatcherServlet(...) calls createDispatcherServlet which returns a DispatcherServlet instance whereas MessageDispatcherServlet directly derives from FrameworkServlet. Both DispatcherServlet and MessageDispatcherServlet have the same base class in common that said FrameworkServlet.
Solution:
AbstractDispatcherServletInitializer.registerDispatcherServlet(...) should return FrameworkServlet in order to support both Spring MVC's DispatcherServlet and Spring-WS's MessageDispatcherServlet.
A pull request with a fix will be provided via Github.
Affects: 4.2.2
Referenced from: commits c1c07bb