Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UndertowRequestUpgradeStrategy not compatible with WildFly anymore [SPR-13619] #18197

Closed
spring-projects-issues opened this issue Oct 28, 2015 · 3 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 28, 2015

Juergen Hoeller opened SPR-13619 and commented

The changes triggered by #18106 kept UndertowRequestUpgradeStrategy compatible with Undertow 1.3 standalone and embedded, but broke general compatibility with WildFly due to an odd side effect of proxy class instantiation with WildFly's strict ClassLoader - on some JVMs at least. Let's fix this for 4.2.3 through reverting back to the regular inner class for the HttpUpgradeListener in our upgradeInternal implementation, keeping the rest of our reflective adaptation in place for general Undertow 1.2 vs 1.3 bridging.


Affects: 4.2.2

Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 28, 2015

Rossen Stoyanchev commented

Brian Clozel could you verify if this fix works for you?

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 29, 2015

Brian Clozel commented

Thanks Rossen Stoyanchev, this fix works for me - I've just closed #18056

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 29, 2015

Rossen Stoyanchev commented

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants