Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UndertowRequestUpgradeStrategy not compatible with WildFly anymore [SPR-13619] #18197

Closed
spring-issuemaster opened this issue Oct 28, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Oct 28, 2015

Juergen Hoeller opened SPR-13619 and commented

The changes triggered by #18106 kept UndertowRequestUpgradeStrategy compatible with Undertow 1.3 standalone and embedded, but broke general compatibility with WildFly due to an odd side effect of proxy class instantiation with WildFly's strict ClassLoader - on some JVMs at least. Let's fix this for 4.2.3 through reverting back to the regular inner class for the HttpUpgradeListener in our upgradeInternal implementation, keeping the rest of our reflective adaptation in place for general Undertow 1.2 vs 1.3 bridging.


Affects: 4.2.2

Issue Links:

  • #18056 Compatibility with WildFly 10 ("is depended on by")
  • #18106 ClassNotFoundException: org.xnio.StreamConnection in Wildfly 10.0.0.CR2
  • #18171 Make use of native doUpgrade operation in Undertow 1.3.5+ / 1.4
@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 28, 2015

Rossen Stoyanchev commented

Brian Clozel could you verify if this fix works for you?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 29, 2015

Brian Clozel commented

Thanks Rossen Stoyanchev, this fix works for me - I've just closed #18056

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 29, 2015

Rossen Stoyanchev commented

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.