Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement containsKey for HttpHeaders returned from ServletServerHttpResponse [SPR-13668] #18243

Closed
spring-projects-issues opened this issue Nov 11, 2015 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Nov 11, 2015

Rob Winch opened SPR-13668 and commented

As currently implemented ServletServerHttpResponse.getHeaders().containsKey(String) always returns false for any pre-existing headers in the underlying HttpServletResponse. We should override the containsKey method or modify how the parent HttpHeaders class behaves so that the HttpServletResponse is consulted.

I'm logging this issue pretty quickly so I don't forget. There may be other methods on ServletResponseHttpHeaders that need fixed.

Note that this impacts the fix for #18124 since the intent is to only set the Content-Disposition if it has not been set.


Affects: 4.1.8, 4.2.2

Backported to: 4.1.9

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.2.3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants