Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caffeine caching support [SPR-13690] #18265

Closed
spring-issuemaster opened this issue Nov 15, 2015 · 4 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Nov 15, 2015

Ben Manes opened SPR-13690 and commented

Caffeine is a Java 8 rewrite of Guava's cache. It provides an updated API, a few missing features, significantly higher performance, and a near optimal hit rate.

A pull request providing this improvement has been provided.


Reference URL: #921

Issue Links:

  • #18370 Drop Guava caching - superseded by Caffeine ("is depended on by")

Referenced from: commits 3a238a2, 13aabee

1 votes, 6 watchers

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Dec 9, 2015

Juergen Hoeller commented

A nice article about Caffeine: https://www.voxxed.com/blog/2015/12/add-a-boost-of-caffeine-to-your-java/
Even if the JCache API is being recommened there, I suppose direct Spring cache adapters still make sense...

BTW, we're going to start the 4.3 line in just about a week. We can roll this pull request in right away then.

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Dec 9, 2015

Ben Manes commented

A built-in Spring cache adapter would be great! I'm not a fan of JCache and I was pleasantly surprised by how simple your Guava adapters were to base this on, so much so that adding myself to the author tag was probably premature. =)

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Dec 9, 2015

Ben Manes commented

I was just informed that Spring Boot configures using Guava's CacheBuilderSpec. I hadn't seen it used anywhere but internal to Google and haven't had the pleasure of using Spring since the 2.x days. If that would simplify integration then I can add a CaffeineSpec that mirrors Guava's.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Dec 10, 2015

Stéphane Nicoll commented

I don't think that's necessary Ben. Spring Boot simply integrates with the API at hand. Once your PR is merged, I'll integrate caffeine support in Spring Boot 1.4 right the way. If you have ideas to smooth the integration for Spring Boot users, feel free to reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.