Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CGLIB 3.2.2 [SPR-13934] #18506

Closed
spring-issuemaster opened this issue Feb 9, 2016 · 6 comments
Closed

Upgrade to CGLIB 3.2.2 [SPR-13934] #18506

spring-issuemaster opened this issue Feb 9, 2016 · 6 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Feb 9, 2016

Rodrigo Ezequiel Merino opened SPR-13934 and commented

The next patch version of cglib has been requested (cglib/cglib#61) which provides a fix (cglib/cglib#50) for a permgen memory leak.

It would be great if this upgrade can also be done in the 4.1.x line.

Ref:


Affects: 4.2.4

Reference URL: #15202

Issue Links:

  • #15202 CGLIB PermGen memory leaks under Karaf
  • #17937 Upgrade to CGLIB 3.2
  • #18609 Upgrade to ASM 5.1
  • #18958 Upgrade to CGLIB 3.2.4
  • #19713 Upgrade to CGLIB 3.2.5

Referenced from: commits dc7ec44, 2b6ec6a

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Feb 9, 2016

Juergen Hoeller commented

Our CGLIB 3.2 upgrade only happened in 4.2.3, so I'm afraid that any further upgrades are bound to 4.2.x and higher. 4.2.5 is scheduled for Feb 18 which is a bit tight; if CGLIB 3.2.1 won't be released in time for that, the next opportunity will be 4.2.6 in early May.

Please note that there won't be any further 4.1.x releases in any case; 4.1.9 in December was the last one in that branch. We expect everybody to upgrade to 4.2.5+ from there. Likewise, 4.2.9 will be released in late 2016, with us expecting everybody to upgrade to 4.3.x from there.

Juergen

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Feb 13, 2016

Juergen Hoeller commented

Stéphane Nicoll, according to the release request on GitHub, the CGLIB 3.2.1 release is imminent, so let's aim for getting it repackaged into 4.2.5... even if it means delaying our release for a few days. Aiming for Feb 22 at the moment, just in time for Boot 1.3.3 / 1.4.0 M1.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Feb 16, 2016

Juergen Hoeller commented

It looks like the CGLIB won't be happening in time, due to API compatibility concerns (cglib/cglib#61 (comment)), and we're not going to delay beyond Feb 22 on our end. Scheduling for 4.3 instead; it remains to be seen whether we can backport this to a later 4.2.x release but it can certainly make 4.3 at least.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Feb 23, 2016

Juergen Hoeller commented

And one more update: As posted on the CGLIB ticket last night, CGLIB 3.2.1 is likely to be released today, so we're waiting until tomorrow (Feb 23) now.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Feb 24, 2016

Juergen Hoeller commented

Unfortunately, CGLIB 3.2.1 is not a seamless upgrade: Our tests for the reuse of generated proxy classes break now. I'll see what I can find out tomorrow morning.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Feb 24, 2016

Juergen Hoeller commented

Moving this one back to 4.3, as per the discussion on cglib/cglib#61, waiting for CGLIB 3.2.2 to fix the CallbackFilter equality regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.