Improve CacheOperation equals/hashCode implementation performance [SPR-13970]

[spring-projects-issues]

Khaled Ayoubi opened SPR-13970 and commented

"CacheAspectSupport" tries to get a cached version of "CacheOperationMetadata" from "metadataCache" using "CacheOperationCacheKey" as a key

"CacheOperationCacheKey.equals" method calls "CacheOperation.equals" which calls "toString" which is pretty expensive, if I'm in large loop and hitting the cache, I can notice considerable degradation in performance

---

Affects: 4.2.4

Issue Links:

• Inefficient equals logic in Spring Cache [SPR-16000] #20549 Inefficient equals logic in Spring Cache ("is duplicated by")
• @Cacheable annotation lead to a huge memory allocation from the side of OperationCache equals/hashCode [SPR-16490] #21033 @Cacheable annotation lead to a huge memory allocation from the side of OperationCache equals/hashCode ("is duplicated by")

[spring-projects-issues]

Stéphane Nicoll commented

This is actually fixed (see #957). If you could give 4.3.0.BUILD-SNAPSHOT a try and confirm this fixed the issue for you, that'd be nice!

[spring-projects-issues]

Khaled Ayoubi commented

this brought down the 2000+ cache hit time from ~700ms to ~200ms! if i have the same data in local map the time is ~30ms, is that expected ?

[spring-projects-issues]

Stéphane Nicoll commented

What is expected? If you have questions, please ask them on Stackoverflow; I really don't see the link with this issue.