New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Support for pebble templates in Spring Web MVC [SPR-14062] #18634

Closed
spring-issuemaster opened this Issue Mar 16, 2016 · 4 comments

Comments

Projects
None yet
1 participant
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Mar 16, 2016

Sachin Walia opened SPR-14062 and commented

Pebble templates are popular and very high in performance compared to most of the competing frameworks. It'll be nice to have it natively supported by the Spring community where it may have much higher chance of recognition.

https://github.com/PebbleTemplates/pebble


Issue Links:

  • #18368 Remove Velocity support
@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Mar 16, 2016

Rossen Stoyanchev commented

I'm no expert on that but the license could be a concern.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Mar 16, 2016

Sachin Walia commented

I'll reach out to developer as well. However can you tell me what could be the concern in license?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Mar 16, 2016

Rossen Stoyanchev commented

As I said I'm not an expert but a simple question would be why is it not a commonly used license?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Mar 16, 2016

Juergen Hoeller commented

Also, please note that we do not aim for the general inclusion of all supported template engines in the Spring core distribution. Quite on the contrary, we're going to remove Velocity support in Spring Framework 5.0, leaving us with just FreeMarker template views and Groovy markup views (as well as JSP if we're willing to count it here) in the core spring-webmvc module.

For a common reference, Thymeleaf is very popular but not actually shipped by ourselves; they rather ship Spring MVC view support in their own distribution. I would recommend the same for Pebble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment