@RequestHeader HttpHeaders fails with NPE against null header value [SPR-14091]

[spring-issuemaster]

Izek Greenfield opened SPR-14091 and commented

@RequestMapping(method = Array[RequestMethod](RequestMethod.POST), consumes = Array[String](MediaType.APPLICATION_JSON_VALUE), produces = Array[String](MediaType.APPLICATION_JSON_VALUE))
     def  doPost(request: HttpServletRequest,
              @RequestHeader httpHeaders: HttpHeaders,
              @RequestBody body: String) = {
}

When I send request with null header:

ffff:

Spring MVC failed with NPE in: RequestHeaderMapMethodArgumentResolver.java:69

for (Iterator<String> iterator = webRequest.getHeaderNames(); iterator.hasNext();) {
                String headerName = iterator.next();
                for (String headerValue : webRequest.getHeaderValues(headerName)) {
                    result.add(headerName, headerValue);
                }
            }

---

Affects: 3.2.16, 4.2.5

Issue Links:

• #18734 NPE thrown when calling methods with an empty @Caching annotation

Backported to: 3.2.17

[spring-issuemaster]

Juergen Hoeller commented

Good catch: getHeaderValues may return null, so we need to add an explicit check there. Done for 4.3 now; to be backported to 4.2.6 and 3.2.17.