Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransportHandlingSockJsService.scheduleSessionTask() doesn't log removed sessions [SPR-14111] #18683

Closed
spring-issuemaster opened this issue Apr 4, 2016 · 1 comment
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 4, 2016

Andrey Borisov opened SPR-14111 and commented

try {
  if (session.getTimeSinceLastActive() > getDisconnectDelay()) {
  sessions.remove(session.getId());
  session.close();
}
}

code is not adding expired session to LIST 'removedSessionIds', hence logging is not working as expected


Affects: 4.2.5

Referenced from: commits d554229, 01d50e9

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 4, 2016

Rossen Stoyanchev commented

This should be fixed now thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.