Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce deprecated addConstructorArg method (again) [SPR-14123] #18695

Closed
spring-issuemaster opened this issue Apr 6, 2016 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 6, 2016

Martin Lippert opened SPR-14123 and commented

class: BeanDefinitionBuilder
method: addConstructorArg(Object value)

This method got removed a while ago. But it caused some incompatibilities with older handler implementations (and older Spring Security versions). Therefore it got re-introduced in this commit:

1e64eed

Unfortunately this method got removed again in this commit:

9ac02b3

and it seems to cause some issues for people (in Spring IDE when using older library versions of Spring Security, in this case, mentioned in the reference URL).

So it would be great if this method could be re-re-introduced back into the code base.


Affects: 4.2.5, 4.3 RC1

Reference URL: https://issuetracker.springsource.com/browse/STS-4339

Issue Links:

  • #17179 Remove pre-3.2 deprecated classes and methods
  • #18700 Deprecate MultiActionController and Controller*NameHandlerMapping

Referenced from: commits 4ea4257, 7659101

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 6, 2016

Juergen Hoeller commented

Ouch, this hurts :-) Seriously, a method deprecated in 2007 turned out to still matter in 2013 because of an old Spring Security generation which ended in 2011, so we gave it another two years... and now we have to reintroduce it in 2016, for a lifetime up until 2019, because of the same old Spring Security line?

At some point we need to reject the use of such outdated Spring Security versions. I'm willing to give in once more, but as of 5.0, this method - along with all other deprecated methods - will be gone for good.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 6, 2016

Martin Lippert commented

I completely understand the reasons for that, Juergen. And I agree that deprecated methods should all be removed for Spring 5. There are a couple of side effects of this on the Spring IDE implementation (since it uses this strange combination of project and IDE classpath lib versions), but that should have no major effect on the framework development. We need a different mechanism in Spring IDE anyway, but that is a major work item. Sounds like we need to tackle this for the Spring 5 timeline, finally.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 6, 2016

Martin Lippert commented

And thanks a lot for your quick help with this, much appreciated!!!!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.