AbstractWebSocketSession.sendMessage race condition [SPR-14138]

[spring-issuemaster]

Karsten Sperling opened SPR-14138 and commented

AbstractWebSocketSession.sendMessage() checks if the connection is still open via isOpen() and throws an IllegalArgumentException if not. However this does not guarantee that the connection will still be open by the time the underlying WS implementation actually tries to write. This means the caller still has to catch / handle the relevant IOException anyway.

It is also impossible for the caller to avoid this exception as the remote side can close the connection at any time, so calling isOpen() before sendMessage() would suffer from exactly the same problem. The correct approach for this kind of situation is to simply attempt the IO operation and to let it fail naturally with an IOException in the underlying implementation if the connection has in fact been closed.

So I suggest to completely remove the Assert.isTrue(isOpen(), ...); check.

---

Affects: 4.2.5, 4.3 RC1

Referenced from: commits e67a274, aafd46a

[spring-issuemaster]

Venil Noronha commented

Hi,

I've implemented a fix for this issue and have created a pull request under the branch 4.2.x. Please review and merge.

My CLA Number is 149720151120072904.

Thanks,
Venil Noronha

[spring-issuemaster]

Rossen Stoyanchev commented

Thanks for the PR.