Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add documentation and examples on reactive WebSockets [SPR-15700] #18762

Closed
spring-issuemaster opened this issue Jun 23, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jun 23, 2017

Mikhail Konovalov opened SPR-15700 and commented

The only lines in docs now

On the client side create a WebSocketClient for one of the supported libraries listed above:

WebSocketClient client = new ReactorNettyWebSocketClient();
client.execute("ws://localhost:8080/echo"), session -> ...).blockMillis(5000);

And that's it.
I think it's definitely not enough.
Here are more examples for JS client on the internet ando absolutely no for server-to-server interaction.
I'd like to get more on how to authorize, how to manipulate messages, if messages in json how to add marshaller and so on.
I beleive we need to add slightly more complicated example than simple echo.

Thank you in advance.


Affects: 5.0 RC2

This issue is a sub-task of #19715

Referenced from: commits 536e72c, 0dd31b8

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 14, 2017

Rossen Stoyanchev commented

The WebFlux section now includes a WebSocket chapter.

Note that currently WebFlux provides only raw WebSocket support. You have to decide what's in each message and how to manipulate it. You can use the Encoder and Decoder implementations available in spring-core and spring-web (JSON, XML, etc) but again you have to first have some protocol about what each message contains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.