Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support manual ACK and NACK in Stomp Client [SPR-14208] #18782

Closed
spring-issuemaster opened this issue Apr 22, 2016 · 1 comment
Closed

Support manual ACK and NACK in Stomp Client [SPR-14208] #18782

spring-issuemaster opened this issue Apr 22, 2016 · 1 comment

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 22, 2016

Nicklas Johnson opened SPR-14208 and commented

Currently it is possible to indicate when creating a new stomp session (via StompHeaders using the WebSocketStompClient) that manual acknowledgment is desired (via subscribeHeaders.setAck); however, there's no API for actually performing the manual ACK/NACK upon receiving a message (or later).

It would be nice if there were methods on the StompSession for sending an ACK or NACK for a message ID. Extra nice would be having the StompSession passed in to StompSessionHandler#handleFrame, making doing the ACK or NACK easy. Then the manual acknowledgment feature would be functional and easy to use.

Ideally such a change should work while being agnostic of transport; for our specific use case, we utilize stomp over websockets.


Affects: 4.2.5

Referenced from: commits 06b2d2b

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 25, 2016

Rossen Stoyanchev commented

We can add methods to the StompSession for 4.3 still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.