Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hard logging of WebApplicationInitializer classes [SPR-14213] #18787

Closed
spring-issuemaster opened this issue Apr 24, 2016 · 2 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 24, 2016

Phil Webb opened SPR-14213 and commented

SpringServletContainerInitializer currently finds, initializes and logs all WebApplicationInitializer implementations in onStartup. With Spring Boot this can be a little confusing because initializers might be conditional. We can't use the usual @Condition annotation since the ApplicationContext hasn't been created yet, but perhaps we could add a ConditionalWebApplicationInitializer extension to WebApplicationInitializer with an additional isActive() method.

See spring-projects/spring-boot#5778 for the original Boot bug.


Affects: 4.2.5, 4.3 RC1

Referenced from: commits 6a3d494, f73df2e

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 25, 2016

Juergen Hoeller commented

I guess we could also consider other ways to avoid confusing log entries, e.g. to not log at that level at all...

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 25, 2016

Juergen Hoeller commented

I've trimmed the log statement to just mention the number of initializers found, not listing the concrete classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.